[haiku-commits] Re: haiku: hrev43773 - in src: apps/activitymonitor kits/interface

  • From: Philippe Saint-Pierre <stpere@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 23 Feb 2012 07:23:20 -0500

> Hm, I would change this a bit. Your solution puts too much thinking and
> knowledge into BControlLook, where it doesn't (IMHO) belong and leaves too
> little flexibility to the user. What if I want to render text onto an image
> that looks like labels on the desktop? I can't, since the view I render
> into is not the Desktop.
> So instead of B_IGNORE_OUTLINE, make a reverse flag. And maybe one for
> each outline drawing mode (glow and shadow). Then you may or may not leave
> the Desktop background info stuff out of BControlLook. I would find it
> cleaner if it would be moved out of there. I don't know, perhaps put it
> into BScreen, where one can already ask for the current Desktop background
> color, if memory serves. How you implemented this with Tracker updating
> this stuff feels somehow like a layering violation.

So basically I would have 3 flags, B_OUTLINE_AUTO, B_OUTLINE_GLOW and
B_OUTLINE_SHADOW?  Sounds fair.  I'll rework it this weekend.  I too was
concerned about some design choices, which is why I requested comments
first in the ML ;-)

I also noticed some places where BControlLook.h is only conditionnally
included (#ifdef __HAIKU__..), ActivityMonitor comes to mind.  But then
be_control_look was already mentionned elsewhere in the sources.  I wonder
if I should #ifdef those calls to, just in case.

Philippe Saint-Pierre

Other related posts: