> Hi Fredrik, > > Am 29.01.2012 00:09, schrieb fredrik@xxxxxxxxx: >> diff --git a/src/kits/media/MediaRoster.cpp >> b/src/kits/media/MediaRoster.cpp >> index 82c69c7..c857652 100644 >> --- a/src/kits/media/MediaRoster.cpp >> +++ b/src/kits/media/MediaRoster.cpp >> @@ -1921,7 +1921,7 @@ BMediaRosterEx::RegisterNode(BMediaNode* node, >> media_addon_id addOnID, >> BMediaAddOn* addon = node->AddOn(&testFlavorID); >> >> ASSERT(addOnID == (addon != NULL ? addon->AddonID() : -1)); >> - ASSERT(flavorID == testFlavorID); >> +// ASSERT(flavorID == testFlavorID); >> ); > > Assertion is a widely used programming technique - just google for the > term to get some info about it. ;-) > > ASSERT was set here to check the case of equality of parameters that > must be true in normal case. It was intentionally set by original > developer in hope to catch fail cases during future development. If you > run into it that means that something _already_ goes bad in your > program. You have to clear why the comparison is wrong here instead of > just disabling the assertion. Of course this check can be obsoleted > nowadays but I suspect that is not the case. ;-) That I will check :) this how it looks like and also the comment. Next I will se what's flavorID and testFlavorID returns :) // some sanity check // I'm not sure if the media kit warrants to call BMediaNode::AddOn() here. // Perhaps we don't need it. DEBUG_ONLY( int32 testFlavorID; BMediaAddOn* addon = node->AddOn(&testFlavorID); ASSERT(addOnID == (addon != NULL ? addon->AddonID() : -1)); // ASSERT(flavorID == testFlavorID); ); -- MVH Fredrik Modèen