hrev43631 adds 1 changeset to branch 'master' old head: b5c5640ec03af45d19c7a0e0758c3c66d71c2095 new head: 8df5e79d2c734f683be421eb997d72d1d205fc23 ---------------------------------------------------------------------------- 8df5e79: Tracker: FSMoveToTrash(): needless check and possible crash fix In an earlier commit, I removed a memleak, but it was covering more cases than intended. Thanks to Alex Wilson's insight, it seems that simply removing the check is better (since that check is essentially redone in FSMoveToTrash()). [ Philippe Saint-Pierre <stpere@xxxxxxxxx> ] ---------------------------------------------------------------------------- Revision: hrev43631 Commit: 8df5e79d2c734f683be421eb997d72d1d205fc23 URL: http://cgit.haiku-os.org/haiku/commit/?id=8df5e79 Author: Philippe Saint-Pierre <stpere@xxxxxxxxx> Date: Thu Jan 5 22:52:21 2012 UTC ---------------------------------------------------------------------------- 1 files changed, 2 insertions(+), 4 deletions(-) src/kits/tracker/Tracker.cpp | 6 ++---- ---------------------------------------------------------------------------- diff --git a/src/kits/tracker/Tracker.cpp b/src/kits/tracker/Tracker.cpp index c5d96ee..5fe7f0b 100644 --- a/src/kits/tracker/Tracker.cpp +++ b/src/kits/tracker/Tracker.cpp @@ -600,10 +600,8 @@ TTracker::MoveRefsToTrash(const BMessage *message) srcList->AddItem(new entry_ref(ref)); } - if (srcList->CountItems()) - // async move to trash - FSMoveToTrash(srcList); - delete srcList; + // async move to trash + FSMoveToTrash(srcList); }