[haiku-commits] haiku: hrev43580 - src/add-ons/kernel/bus_managers/acpi

  • From: stpere@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 29 Dec 2011 23:40:56 +0100 (CET)

hrev43580 adds 1 changeset to branch 'master'
old head: 5e783d6ad73c7af5bd5cf3315633d2e9f95bb44f
new head: eb945927039423f42dd37fd6bbb8190c2976c410

----------------------------------------------------------------------------

eb94592: acpi_manager: Uninit var returned in EcRead()
  
  In case of failure in EcRead(), rather than returning the proper status,
  an uninit variable was returned. CID 11145.

                                [ Philippe Saint-Pierre <stpere@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev43580
Commit:      eb945927039423f42dd37fd6bbb8190c2976c410
URL:         http://cgit.haiku-os.org/haiku/commit/?id=eb94592
Author:      Philippe Saint-Pierre <stpere@xxxxxxxxx>
Date:        Thu Dec 29 22:37:58 2011 UTC

----------------------------------------------------------------------------

1 files changed, 1 insertions(+), 1 deletions(-)
.../bus_managers/acpi/acpi_embedded_controller.cpp |    2 +-

----------------------------------------------------------------------------

diff --git a/src/add-ons/kernel/bus_managers/acpi/acpi_embedded_controller.cpp 
b/src/add-ons/kernel/bus_managers/acpi/acpi_embedded_controller.cpp
index 92ed85b..9cbfbc7 100644
--- a/src/add-ons/kernel/bus_managers/acpi/acpi_embedded_controller.cpp
+++ b/src/add-ons/kernel/bus_managers/acpi/acpi_embedded_controller.cpp
@@ -825,7 +825,7 @@ EcRead(struct acpi_ec_cookie* sc, uint8 address, uint8* 
readData)
 
        acpi_status status;
        for (uint8 retry = 0; retry < 2; retry++) {
-               acpi_status status = EcCommand(sc, EC_COMMAND_READ);
+               status = EcCommand(sc, EC_COMMAND_READ);
                if (status != AE_OK)
                        return status;
 


Other related posts:

  • » [haiku-commits] haiku: hrev43580 - src/add-ons/kernel/bus_managers/acpi - stpere