[haiku-commits] haiku: hrev43491 - src/apps/debugger

  • From: anevilyak@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 13 Dec 2011 21:55:00 +0100 (CET)

hrev43491 adds 1 changeset to branch 'master'
old head: e4a8cf983d222701e64ba57bbc6f58b49ad9aab0
new head: 6b5a76158feca98428a70bab266358fb82fb270d

----------------------------------------------------------------------------

6b5a761: Add TODO note.

                                      [ Rene Gollent <anevilyak@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev43491
Commit:      6b5a76158feca98428a70bab266358fb82fb270d
URL:         http://cgit.haiku-os.org/haiku/commit/?id=6b5a761
Author:      Rene Gollent <anevilyak@xxxxxxxxx>
Date:        Tue Dec 13 20:52:05 2011 UTC

----------------------------------------------------------------------------

1 files changed, 5 insertions(+), 1 deletions(-)
src/apps/debugger/ThreadHandler.cpp |    6 +++++-

----------------------------------------------------------------------------

diff --git a/src/apps/debugger/ThreadHandler.cpp 
b/src/apps/debugger/ThreadHandler.cpp
index b2262f3..99f14b5 100644
--- a/src/apps/debugger/ThreadHandler.cpp
+++ b/src/apps/debugger/ThreadHandler.cpp
@@ -481,7 +481,7 @@ ThreadHandler::_DoStepOver(CpuState* cpuState)
 
        TRACE_CONTROL("  subroutine call -- installing breakpoint at address "
                "%#llx\n", info.Address() + info.Size());
-
+       
        if (_InstallTemporaryBreakpoint(info.Address() + info.Size()) != B_OK)
                return false;
 
@@ -565,6 +565,10 @@ ThreadHandler::_HandleBreakpointHitStep(CpuState* cpuState)
                                        _StepFallback();
                                return true;
                        }
+
+                       // TODO: this needs to handle recursive cases properly 
as
+                       // STEP_OUT does, we need to have exited the statement
+                       // *and* be back in the call frame we started in. 
                        return false;
 
                case STEP_INTO:


Other related posts: