[haiku-commits] Re: haiku: hrev43483 - in src/apps/debugger: . arch/x86 arch
- From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 12 Dec 2011 15:30:06 +0100
anevilyak@xxxxxxxxx wrote:
> hrev43483 adds 4 changesets to branch 'master'
> old head: 7bdc07318d18bdfdce77125cc51a7f2a157cdc95
> new head: f67acc2c72cf11d2f7cd478af67a6493984fd683
>
> ----------------------------------------------------------------------------
>
> 12b1aa8: Expose the stack pointer and frame pointer via CPUState.
>
> 673c1e4: Fix step out for recursive functions.
>
> When asked to step out, we now store the frame pointer of the current
> stack frame. Upon hitting our temporary breakpoint, we then verify that
> the current frame pointer is in fact in the previous frame. If not, we
> reinstate the breakpoint and continue running.
>
> 4b64cd3: Add architecture function for retrieving the stack growth direction.
>
> Also add corresponding implementation for x86.
>
> f67acc2: Use architecture to determine correct frame pointer comparison.
BTW, in such a case where a commit fixes/improves an earlier not yet pushed
commit I would totally recommend rewriting them to keep the history nicer. In
this case it would consist of a "git rebase -i 12b1aa8" (which opens an editor
with the list of commits), swapping 673c1e4 and 4b64cd3, squashing f67acc2, and
finally editing the commit message for the joined 673c1e4/f67acc2. Probably
done in about 30 s. Wonderful feature.
CU, Ingo
Other related posts:
