[haiku-commits] Re: haiku: hrev43356 - src/kits/tracker
- From: Philippe Saint-Pierre <stpere@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 29 Nov 2011 08:33:23 -0500
>
>> By the way, another example of such silly "errors" is a fallthrough case
>> in
>> switch that is absolutely legal programming construction.
>
> Sure, but to make it clear, one should always add a comment like
> "intentional fall-through". I don't know if Coverity is smart enough to
> detect such comments, though -- for a human developer, it's definitely a
> good thing to add :-)
And to give some justice to Coverity, the missing break statements are
clearly worded as not an error.. but as a potential error, and invite
to verify if that's intentational. If that's the case, you put the
report as "Intentional" and action to "ignore" and you're done. And
there is nothing much more frustrating as an intentional fallthrough
that is not commented as such :) Well, yes, there are more
frustrating things, but you see my point.. ;-)
Philippe
Other related posts:
