[haiku-commits] Re: haiku: hrev43356 - src/kits/tracker

  • From: marcus overhagen <marcusoverhagen@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 29 Nov 2011 11:13:25 +0100

On Tue, Nov 29, 2011 at 10:36 AM, Oliver Tappe <zooey@xxxxxxxxxxxxxxx> wrote:

> >>        status_t error = item->InitCheck();
> >>        if (error != B_OK)
> >> +               throw (status_t)error;
> >
> > Is this typecast really needed?
> >
> > regards
> > Marcus

> If you throw B_NO_MEMORY, you *can't* catch it as status_t, because it
> isn't (B_MEMORY is an int). Try for yourself:
Agreed!

I was only referring to the second part of the commit, because throwing
a status_t variable 'error' should not need a typecast, and shouldn't trigger
a Coverity warning (but I didn't verify that beforehand, sorry).

regards
Marcus

Other related posts: