[haiku-commits] Re: another coding style discussion (was: r36596 - haiku/trunk/src/apps/packageinstaller)
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 04 May 2010 15:37:21 +0200
Stephan Assmus <superstippi@xxxxxx> wrote:
> > To me this is clearly a single line statement "continue;", the
> > condition readability is another thing.
> This isn't directed at you in particular, Jérôme, but I have to say
> that I
> find these coding style discussions often frustrating and ridiculous.
> I absolutely agree that everyone should follow the style, and I am
> happy to
> point out style issues in patches from newcomers and even oldtimers.
> I
> dislike when code gets checked in that doesn't follow the style, but
> it's not
> the order of headers and similar things like how many blank lines
> after the
> copyright and whatnot that I find annoying. After a certain point it
> just
> gets ridiculous and counter-productive.
There is no problem as long everyone stick to it. It only gets
problematic if people don't adhere to it. Since having a coding style
is definitely worthwhile IMO, I don't see much room for alternatives
here.
The only thing really counter-productive is talking about it on this
level IMO.
> As you point out yourself, you
> reserve judgement on readability of the multi-line if clause. That I
> always
> interpreted the rule the way I did is a clear indication that the
> coding
> guidelines are not clear "enough".
Such is language, but as I said earlier, in this case the coding style
guide is pretty specific IMO.
In other cases, feel free to improve it. If unsure, feel free to ask on
the list, and we'll sort it out together. If you like to change
specific things, start a vote. The coding style is a formalism you can
easily get used to and follow.
Bye,
Axel.
Other related posts:
