[haiku-commits] Re: ***UNCHECKED*** haiku: hrev53665 - src/kits/locale

  • From: "Alexander von Gluck IV" <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 31 Dec 2019 15:19:26 +0000

December 31, 2019 7:40 AM, "Adrien Destugues" <pulkomandy@xxxxxxxxx> wrote:

hrev53665 adds 1 changeset to branch 'master'
old head: 32158f3d64fd2c2c2a77a6777d70af163e7a944b
new head: d57174ea94a619fea7b52eba3b79b4be40e7063b
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=d57174ea94a6+^32158f3d64fd

----------------------------------------------------------------------------

d57174ea94a6: BLanguage: check locale validity in SetTo.

Fixes #15514

[ Adrien Destugues <pulkomandy@xxxxxxxxxxxxx> ]


+ if (fICULocale.IsBogus())
+ return B_BAD_VALUE;
+

../haiku-git/src/kits/locale/Language.cpp: In method `status_t 
BLanguage::SetTo(const char *)':
../haiku-git/src/kits/locale/Language.cpp:69: request for member `IsBogus' in 
`BLanguage::fICULocale', which is of non-aggregate type `icu_57::Locale *'


This broke all the builds.

 -- Alex

Other related posts: