On Thu, Aug 06, 2020 at 12:11:08PM -0400, John Scipione wrote:
On Thu, Aug 6, 2020 at 8:57 AM Rene Gollent <anevilyak@xxxxxxxxx> wrote:
On Thu, 6 Aug 2020 at 08:52, Alexander G. M. Smith <agmsmith@xxxxxx> wrote:
I see that a new field fAlignedTextRect was added to
headers/os/interface/TextView.h and some padding was removed. But
shouldn't the new field go where the padding was removed? Otherwise
binaries built with the earlier headers will look for some fields
at the wrong offsets into the structure.
That shouldn't be the case, since they're private fields only accessed
by class functions, none of which are inline. As such, only the code
in libbe is accessing them, and that's been rebuilt in conjunction
with this change.
I see PulkoMandy went with the 4 byte BRect version instead of using a
pointer - that solves the 32/64 bit class size issue but now we're
down to just two more extra private member bytes. I'll have to look
into how we can extend the BTextView class to add more members. I'm
thinking of adding a BTextViewPrivate class along the lines of the
BMenuPrivate class. We'll need something like this to extend the class
further.
