[haiku-commits] Change in haiku[r1beta2]: nfs: Fix panic occurs when creating a file

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: marbocub <marbocub@xxxxxxxxx>, waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 1 Dec 2020 20:58:24 +0000

From Alex von Gluck IV <kallisti5@xxxxxxxxxxx>:

Hello marbocub,

I'd like you to do a code review. Please visit

    https://review.haiku-os.org/c/haiku/+/3447

to review the following change.


Change subject: nfs: Fix panic occurs when creating a file
......................................................................

nfs: Fix panic occurs when creating a file

Fix an issue #5496 where panic occurs when creating a file with nfs v2
due to the newly generated vnode of the file is not published
and is still busy.

Change-Id: I4482fbe046e000eb799599fdeaab39b7812bd2ac
---
M src/add-ons/kernel/file_systems/nfs/nfs_add_on.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/47/3447/1

diff --git a/src/add-ons/kernel/file_systems/nfs/nfs_add_on.c 
b/src/add-ons/kernel/file_systems/nfs/nfs_add_on.c
index 6bfe7ef..2eedcf7 100644
--- a/src/add-ons/kernel/file_systems/nfs/nfs_add_on.c
+++ b/src/add-ons/kernel/file_systems/nfs/nfs_add_on.c
@@ -1837,8 +1837,8 @@
                (*cookie)->original_size = st.st_size;
                (*cookie)->st = st;

-               result = new_vnode(_volume, *vnid, newNode, &sNFSVnodeOps);
-
+               result = publish_vnode(_volume, *vnid, newNode, &sNFSVnodeOps,
+                       S_IFREG, 0);
                if (result < B_OK) {
                        XDRInPacketDestroy(&reply);
                        XDROutPacketDestroy(&call);

--
To view, visit https://review.haiku-os.org/c/haiku/+/3447
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: r1beta2
Gerrit-Change-Id: I4482fbe046e000eb799599fdeaab39b7812bd2ac
Gerrit-Change-Number: 3447
Gerrit-PatchSet: 1
Gerrit-Owner: Alex von Gluck IV <kallisti5@xxxxxxxxxxx>
Gerrit-Reviewer: marbocub <marbocub@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[r1beta2]: nfs: Fix panic occurs when creating a file - Gerrit