[haiku-commits] Change in haiku[master]: usb_midi: Fix an error when unpluging a MIDI device

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 25 Aug 2019 16:33:17 +0000

Name of user not set #1000079 has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/1746 ;)


Change subject: usb_midi: Fix an error when unpluging a MIDI device
......................................................................

usb_midi: Fix an error when unpluging a MIDI device

  - It appears that, in this case, port->open_fd is NULL.
    Maybe, this would require some investigation too.
    But in this case, i think it is better to remove port
    from the device list anyway.
    Next line (remove_port) will freed the port.
    And adding 0xdeadbeef in the device list is not a good idea.
---
M src/add-ons/kernel/drivers/midi/usb_midi/usb_midi.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/46/1746/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1746
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Id6b55f5e19ebbbbb48f0fa0b7d9ac65b996dbaf2
Gerrit-Change-Number: 1746
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1000079
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: usb_midi: Fix an error when unpluging a MIDI device - Gerrit