[haiku-commits] Change in haiku[master]: servers/app: Fix -Wformat-security

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 22 Oct 2020 12:40:37 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3346 ;)


Change subject: servers/app: Fix -Wformat-security
......................................................................

servers/app: Fix -Wformat-security

Change-Id: Ia2ad0aac295c7a1ce3aafe571ae71f3aa8a4f433
---
M src/servers/app/drawing/interface/remote/RemoteHWInterface.cpp
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/46/3346/1

diff --git a/src/servers/app/drawing/interface/remote/RemoteHWInterface.cpp 
b/src/servers/app/drawing/interface/remote/RemoteHWInterface.cpp
index 4766401..67fe020 100644
--- a/src/servers/app/drawing/interface/remote/RemoteHWInterface.cpp
+++ b/src/servers/app/drawing/interface/remote/RemoteHWInterface.cpp
@@ -402,9 +402,9 @@
        info->version = fProtocolVersion;
        info->dac_speed = fConnectionSpeed;
        info->memory = 33554432; // 32MB
-       snprintf(info->name, sizeof(info->name), "Haiku, Inc. 
RemoteHWInterface");
-       snprintf(info->chipset, sizeof(info->chipset), "Haiku, Inc. Chipset");
-       snprintf(info->serial_no, sizeof(info->serial_no), fTarget);
+       strlcpy(info->name, "Haiku, Inc. RemoteHWInterface", 
sizeof(info->name));
+       strlcpy(info->chipset, "Haiku, Inc. Chipset", sizeof(info->chipset));
+       strlcpy(info->serial_no, fTarget, sizeof(info->serial_no));

        ReadUnlock();
        return B_OK;

--
To view, visit https://review.haiku-os.org/c/haiku/+/3346
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ia2ad0aac295c7a1ce3aafe571ae71f3aa8a4f433
Gerrit-Change-Number: 3346
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: servers/app: Fix -Wformat-security - Gerrit