[haiku-commits] Change in haiku[master]: pch_i2c: add a few more ACPI HID for older chipsets

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 11 Apr 2020 10:03:06 +0000

From Jérôme Duval <jerome.duval@xxxxxxxxx>:

Jérôme Duval has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2469 ;)


Change subject: pch_i2c: add a few more ACPI HID for older chipsets
......................................................................

pch_i2c: add a few more ACPI HID for older chipsets

they should be compatible for I2C I/O
---
M src/add-ons/kernel/busses/i2c/pch_i2c_acpi.cpp
1 file changed, 12 insertions(+), 2 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/69/2469/1

diff --git a/src/add-ons/kernel/busses/i2c/pch_i2c_acpi.cpp 
b/src/add-ons/kernel/busses/i2c/pch_i2c_acpi.cpp
index 6553974..eccdc9f 100644
--- a/src/add-ons/kernel/busses/i2c/pch_i2c_acpi.cpp
+++ b/src/add-ons/kernel/busses/i2c/pch_i2c_acpi.cpp
@@ -120,6 +120,10 @@
                ERROR("Error while getting I2C devices\n");
                return status;
        }
+       if (crs.addr_bas == 0 || crs.addr_len == 0) {
+               TRACE("skipping non configured I2C devices\n");
+               return B_BAD_VALUE;
+       }

        bus->info.base_addr = crs.addr_bas;
        bus->info.map_size = crs.addr_len;
@@ -187,14 +191,20 @@
        }
        TRACE("found an acpi device hid %s\n", name);

-       if (strcmp(name, "INT3442") == 0
+       if (strcmp(name, "INT33C2") == 0
+               || strcmp(name, "INT33C3") == 0
+               || strcmp(name, "INT3432") == 0
+               || strcmp(name, "INT3433") == 0
+               || strcmp(name, "INT3442") == 0
                || strcmp(name, "INT3443") == 0
                || strcmp(name, "INT3444") == 0
                || strcmp(name, "INT3445") == 0
                || strcmp(name, "INT3446") == 0
                || strcmp(name, "INT3447") == 0
                || strcmp(name, "80860AAC") == 0
-               || strcmp(name, "80865AAC") == 0) {
+               || strcmp(name, "80865AAC") == 0
+               || strcmp(name, "80860F41") == 0
+               || strcmp(name, "808622C1") == 0) {
                TRACE("PCH I2C device found! name %s\n", name);
                return 0.6f;
        }

--
To view, visit https://review.haiku-os.org/c/haiku/+/2469
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ifc2bed29813403ef845ca60c9cc22187e2cacc88
Gerrit-Change-Number: 2469
Gerrit-PatchSet: 1
Gerrit-Owner: Jérôme Duval <jerome.duval@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: pch_i2c: add a few more ACPI HID for older chipsets - Gerrit