[haiku-commits] Change in haiku[master]: pairs: remove more dead nested assignment

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 4 Oct 2020 07:22:25 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3288 ;)


Change subject: pairs: remove more dead nested assignment
......................................................................

pairs: remove more dead nested assignment

Pointed out by clang static analyzer.

Change-Id: I21cd0a779a50f26d713ae1203024b2b0f2f4bd49
---
M src/apps/pairs/PairsWindow.cpp
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/88/3288/1

diff --git a/src/apps/pairs/PairsWindow.cpp b/src/apps/pairs/PairsWindow.cpp
index f5ab2b0..72741fb 100644
--- a/src/apps/pairs/PairsWindow.cpp
+++ b/src/apps/pairs/PairsWindow.cpp
@@ -100,13 +100,13 @@
        difficultyMessage = new BMessage(MENU_DIFFICULTY);
        difficultyMessage->AddInt32("rows", 6);
        difficultyMessage->AddInt32("cols", 6);
-       newMenu->AddItem(new BMenuItem(
-               B_TRANSLATE("Intermediate (6x6)"), difficultyMessage));
+       newMenu->AddItem(new BMenuItem(B_TRANSLATE("Intermediate (6x6)"),
+               difficultyMessage));

        difficultyMessage = new BMessage(MENU_DIFFICULTY);
        difficultyMessage->AddInt32("rows", 8);
        difficultyMessage->AddInt32("cols", 8);
-       newMenu->AddItem(menuItem = new BMenuItem(B_TRANSLATE("Expert (8x8)"),
+       newMenu->AddItem(new BMenuItem(B_TRANSLATE("Expert (8x8)"),
                difficultyMessage));

        menuItem = new BMenuItem(newMenu, new BMessage(MENU_NEW));

--
To view, visit https://review.haiku-os.org/c/haiku/+/3288
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I21cd0a779a50f26d713ae1203024b2b0f2f4bd49
Gerrit-Change-Number: 3288
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: pairs: remove more dead nested assignment - Gerrit