[haiku-commits] Change in haiku[master]: file_systems/userlandfs: Fix -Wnonnull-compare

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 29 Oct 2020 10:34:50 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3363 ;)


Change subject: file_systems/userlandfs: Fix -Wnonnull-compare
......................................................................

file_systems/userlandfs: Fix -Wnonnull-compare

In String::SetTo(), strnlen() is called only when *str is not NULL.
This leads to "-Wnonnull-compare" warning at line 12.
So, use system's strnlen() to fix warning.

Change-Id: I55098af4e2c62ebcf3b6105b7b8f186eebf28edf
---
M src/add-ons/kernel/file_systems/userlandfs/shared/String.cpp
1 file changed, 0 insertions(+), 16 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/63/3363/1

diff --git a/src/add-ons/kernel/file_systems/userlandfs/shared/String.cpp 
b/src/add-ons/kernel/file_systems/userlandfs/shared/String.cpp
index 414d585..e0c8466 100644
--- a/src/add-ons/kernel/file_systems/userlandfs/shared/String.cpp
+++ b/src/add-ons/kernel/file_systems/userlandfs/shared/String.cpp
@@ -5,22 +5,6 @@

 #include "String.h"

-// strnlen
-size_t
-strnlen(const char *str, size_t maxLen)
-{
-       if (str) {
-               size_t origMaxLen = maxLen;
-               while (maxLen > 0 && *str != '\0') {
-                       maxLen--;
-                       str++;
-               }
-               return origMaxLen - maxLen;
-       }
-       return 0;
-}
-
-
 /*!
        \class String
        \brief A very simple string class.

--
To view, visit https://review.haiku-os.org/c/haiku/+/3363
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I55098af4e2c62ebcf3b6105b7b8f186eebf28edf
Gerrit-Change-Number: 3363
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: file_systems/userlandfs: Fix -Wnonnull-compare - Gerrit