[haiku-commits] Change in haiku[master]: efi/devices: Skip qemu flash device for now due to crash

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 20 Jul 2020 19:38:57 +0000

From Alex von Gluck IV <kallisti5@xxxxxxxxxxx>:

Alex von Gluck IV has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3049 ;)


Change subject: efi/devices: Skip qemu flash device for now due to crash
......................................................................

efi/devices: Skip qemu flash device for now due to crash

* An upstream bug exists which results in the tianocore
  bios crashing when attempting to read from qemu's
  (unconfigured, but present) flash device.

Change-Id: Ie9f02a290abc29cce3a5e279382750c0b14164dc
---
M src/system/boot/platform/efi/devices.cpp
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/49/3049/1

diff --git a/src/system/boot/platform/efi/devices.cpp 
b/src/system/boot/platform/efi/devices.cpp
index 17cd4a9..82c5f2b 100644
--- a/src/system/boot/platform/efi/devices.cpp
+++ b/src/system/boot/platform/efi/devices.cpp
@@ -155,6 +155,14 @@
                if (!blockIo->Media->MediaPresent || 
blockIo->Media->LogicalPartition)
                        continue;

+               #if defined(__arm__)
+               // The qemu flash device with a 256K block size shows up in 
edk2.
+               // If flash is unconfigured, reads from it result in a efi 
crash.
+               // https://bugzilla.tianocore.org/show_bug.cgi?id=2856
+               if (blockIo->Media->BlockSize == 262144)
+                       continue;
+               #endif
+
                EfiDevice *device = new(std::nothrow)EfiDevice(blockIo);
                if (device == NULL)
                        panic("Can't allocate memory for block devices!");

--
To view, visit https://review.haiku-os.org/c/haiku/+/3049
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ie9f02a290abc29cce3a5e279382750c0b14164dc
Gerrit-Change-Number: 3049
Gerrit-PatchSet: 1
Gerrit-Owner: Alex von Gluck IV <kallisti5@xxxxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: efi/devices: Skip qemu flash device for now due to crash - Gerrit