[haiku-commits] Change in haiku[master]: bin/setversion: Fix if condition

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 25 Jun 2020 10:37:38 +0000

From Murai Takashi <tmurai01@xxxxxxxxx>:

Murai Takashi has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2949 ;)


Change subject: bin/setversion: Fix if condition
......................................................................

bin/setversion: Fix if condition

Fix str = "gm" could not be checked.
Pointed out by cppcheck.

Change-Id: I433a98cef851e07be0905eee2f5100a02fa6a32b
---
M src/bin/setversion.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/49/2949/1

diff --git a/src/bin/setversion.cpp b/src/bin/setversion.cpp
index b27ba12..e99d673 100644
--- a/src/bin/setversion.cpp
+++ b/src/bin/setversion.cpp
@@ -62,7 +62,7 @@
                return 2;
        if (!strcmp(str, "g") || !strcmp(str, "gamma"))
                return 3;
-       if (strcmp(str, "gm") || !strcmp(str, "goldenmaster"))
+       if (!strcmp(str, "gm") || !strcmp(str, "goldenmaster"))
                return 4;
        if (!strcmp(str, "f") || !strcmp(str, "final"))
                return 5;

--
To view, visit https://review.haiku-os.org/c/haiku/+/2949
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I433a98cef851e07be0905eee2f5100a02fa6a32b
Gerrit-Change-Number: 2949
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: bin/setversion: Fix if condition - Gerrit