[haiku-commits] Change in haiku[master]: app_server: fix crash caused by missing locking

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 7 Jun 2020 14:56:43 +0000

From X512 <danger_mail@xxxxxxx>:

X512 has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2891 ;)


Change subject: app_server: fix crash caused by missing locking
......................................................................

app_server: fix crash caused by missing locking

Change-Id: Ib9b0c2282f947c0c6ac61fc3e97f9eca7af8dda4
---
M src/servers/app/ServerApp.cpp
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/91/2891/1

diff --git a/src/servers/app/ServerApp.cpp b/src/servers/app/ServerApp.cpp
index e2092f6..6250f11 100644
--- a/src/servers/app/ServerApp.cpp
+++ b/src/servers/app/ServerApp.cpp
@@ -922,6 +922,7 @@
                                        int32 token = -1;
                                        link.Read<int32>(&token);

+                                       BAutolock _(fMapLocker);
                                        if (ServerPicture* subPicture = 
_FindPicture(token))
                                                
picture->NestPicture(subPicture);
                                }

--
To view, visit https://review.haiku-os.org/c/haiku/+/2891
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b0c2282f947c0c6ac61fc3e97f9eca7af8dda4
Gerrit-Change-Number: 2891
Gerrit-PatchSet: 1
Gerrit-Owner: X512 <danger_mail@xxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: app_server: fix crash caused by missing locking - Gerrit