[haiku-commits] Change in haiku[master]: app_server: Fall back to style "Regular" before style 0

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 6 Jun 2020 18:35:10 +0000

From Adrien Destugues <pulkomandy@xxxxxxxxx>:

Adrien Destugues has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2887 ;)


Change subject: app_server: Fall back to style "Regular" before style 0
......................................................................

app_server: Fall back to style "Regular" before style 0

Most notably in noto sans cjk style 0 seems be thin or light, and not Regular
this should make the fallback try Regular and only fall back to 0
if no font has a regular variant for the requested glyph
---
M src/servers/app/font/GlyphLayoutEngine.h
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/87/2887/1

diff --git a/src/servers/app/font/GlyphLayoutEngine.h 
b/src/servers/app/font/GlyphLayoutEngine.h
index 97903c4..aba9d49 100644
--- a/src/servers/app/font/GlyphLayoutEngine.h
+++ b/src/servers/app/font/GlyphLayoutEngine.h
@@ -341,10 +341,12 @@
        fallbackEntry = NULL;

        // Try to get the glyph from the fallback fonts.
-       for (int c = 0; c < 2; c++) {
+       for (int c = 0; c < 3; c++) {
                const char* fontStyle;
                if (c == 0)
                        fontStyle = font.Style();
+               else if (c == 1)
+                       fontStyle = "Regular";
                else
                        fontStyle = NULL;


--
To view, visit https://review.haiku-os.org/c/haiku/+/2887
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ib152a50e6cace032278a60f664c2569fa9fe82fc
Gerrit-Change-Number: 2887
Gerrit-PatchSet: 1
Gerrit-Owner: Adrien Destugues <pulkomandy@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: app_server: Fall back to style "Regular" before style 0 - Gerrit