From Panagiotis Vasilopoulos <hello@xxxxxxxxxxxxxxx>:
Panagiotis Vasilopoulos has uploaded this change for review. (
https://review.haiku-os.org/c/haiku/+/3352 ;)
Change subject: WebPositive: Realigned Settings window
......................................................................
WebPositive: Realigned Settings window
The idea is to eventually allow the user to choose between a bunch of
predefined search engines and optionally allowing them to enter their own
search engine, should they want to do so. For that, a greyed out text input
field, which will be ungreyed whenever the user opts for using their own search
engine, will be required. The 'Search page' option will eventually be the most
space-consuming option, so it'd make sense from my perspective to put it in the
bottom of that list, while making it more distinct and grouping together all
options with a text field in the meantime.
---
M src/apps/webpositive/SettingsWindow.cpp
1 file changed, 21 insertions(+), 21 deletions(-)
git pull ssh://git.haiku-os.org:22/haiku refs/changes/52/3352/1
diff --git a/src/apps/webpositive/SettingsWindow.cpp
b/src/apps/webpositive/SettingsWindow.cpp
index f71b925..1f0decf 100644
--- a/src/apps/webpositive/SettingsWindow.cpp
+++ b/src/apps/webpositive/SettingsWindow.cpp
@@ -249,6 +249,14 @@
BView*
SettingsWindow::_CreateGeneralPage(float spacing)
{
+ fDownloadFolderControl = new BTextControl("download folder",
+ B_TRANSLATE("Download folder:"), "",
+ new BMessage(MSG_DOWNLOAD_FOLDER_CHANGED));
+ fDownloadFolderControl->SetModificationMessage(
+ new BMessage(MSG_DOWNLOAD_FOLDER_CHANGED));
+ fDownloadFolderControl->SetText(
+ fSettings->GetValue(kSettingsKeyDownloadPath,
kDefaultDownloadPath));
+
fStartPageControl = new BTextControl("start page",
B_TRANSLATE("Start page:"), "", new
BMessage(MSG_START_PAGE_CHANGED));
fStartPageControl->SetModificationMessage(
@@ -271,14 +279,6 @@
}
fSearchPageControl->SetText(searchURL);
- fDownloadFolderControl = new BTextControl("download folder",
- B_TRANSLATE("Download folder:"), "",
- new BMessage(MSG_DOWNLOAD_FOLDER_CHANGED));
- fDownloadFolderControl->SetModificationMessage(
- new BMessage(MSG_DOWNLOAD_FOLDER_CHANGED));
- fDownloadFolderControl->SetText(
- fSettings->GetValue(kSettingsKeyDownloadPath,
kDefaultDownloadPath));
-
fStartUpBehaviorResumePriorSession = new BMenuItem(
B_TRANSLATE("Resume prior session"),
new BMessage(MSG_START_UP_BEHAVIOR_CHANGED));
@@ -366,24 +366,24 @@
BView* view = BGroupLayoutBuilder(B_VERTICAL, 0)
.Add(BGridLayoutBuilder(spacing / 2, spacing / 2)
- .Add(fStartPageControl->CreateLabelLayoutItem(), 0, 0)
- .Add(fStartPageControl->CreateTextViewLayoutItem(), 1,
0)
+ .Add(fStartUpBehaviorMenu->CreateLabelLayoutItem(), 0,
0)
+ .Add(fStartUpBehaviorMenu->CreateMenuBarLayoutItem(),
1, 0)
- .Add(fSearchPageControl->CreateLabelLayoutItem(), 0, 1)
- .Add(fSearchPageControl->CreateTextViewLayoutItem(), 1,
1)
+ .Add(fNewWindowBehaviorMenu->CreateLabelLayoutItem(),
0, 1)
+ .Add(fNewWindowBehaviorMenu->CreateMenuBarLayoutItem(),
1, 1)
- .Add(fStartUpBehaviorMenu->CreateLabelLayoutItem(), 0,
2)
- .Add(fStartUpBehaviorMenu->CreateMenuBarLayoutItem(),
1, 2)
+ .Add(fNewTabBehaviorMenu->CreateLabelLayoutItem(), 0, 2)
+ .Add(fNewTabBehaviorMenu->CreateMenuBarLayoutItem(), 1,
2)
- .Add(fNewWindowBehaviorMenu->CreateLabelLayoutItem(),
0, 3)
- .Add(fNewWindowBehaviorMenu->CreateMenuBarLayoutItem(),
1, 3)
+ .Add(fDownloadFolderControl->CreateLabelLayoutItem(),
0, 3)
+
.Add(fDownloadFolderControl->CreateTextViewLayoutItem(), 1, 3)
+ .Add(fChooseButton, 2, 3)
- .Add(fNewTabBehaviorMenu->CreateLabelLayoutItem(), 0, 4)
- .Add(fNewTabBehaviorMenu->CreateMenuBarLayoutItem(), 1,
4)
+ .Add(fStartPageControl->CreateLabelLayoutItem(), 0, 4)
+ .Add(fStartPageControl->CreateTextViewLayoutItem(), 1,
4)
- .Add(fDownloadFolderControl->CreateLabelLayoutItem(),
0, 5)
-
.Add(fDownloadFolderControl->CreateTextViewLayoutItem(), 1, 5)
- .Add(fChooseButton, 2, 5)
+ .Add(fSearchPageControl->CreateLabelLayoutItem(), 0, 5)
+ .Add(fSearchPageControl->CreateTextViewLayoutItem(), 1,
5)
)
.Add(BSpaceLayoutItem::CreateVerticalStrut(spacing))
.Add(new BSeparatorView(B_HORIZONTAL, B_PLAIN_BORDER))
--
To view, visit https://review.haiku-os.org/c/haiku/+/3352
To unsubscribe, or for help writing mail filters, visit
https://review.haiku-os.org/settings
Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I461d173dd5a2086b77df5cf96aaf3d7bed58f3ce
Gerrit-Change-Number: 3352
Gerrit-PatchSet: 1
Gerrit-Owner: Panagiotis Vasilopoulos <hello@xxxxxxxxxxxxxxx>
Gerrit-MessageType: newchange
