[haiku-commits] Change in haiku[master]: Revive unit tests

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, Jérôme Duval <jerome.duval@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 25 Aug 2018 13:43:02 +0000

From Kacper Kasper <kacperkasper@xxxxxxxxx>:

Hello waddlesplash, Jérôme Duval, Adrien Destugues,

I'd like you to reexamine a change. Please visit

    https://review.haiku-os.org/465

to look at the new patch set (#4).

Change subject: Revive unit tests
......................................................................

Revive unit tests

* Fix build on 64-bit.
* Test suite can now run from start to finish.
* Changes in OutlineListView test need an explanation:
  for some reason when BApplication is created on heap, be_app is not
  reset. This causes other tests to crash due to second BApplication
  object being created.

Change-Id: Ic7d55f4622192f83572bfd83fa37f1f5fd641e22
---
M src/tests/kits/app/AppKitTestAddon.cpp
M src/tests/kits/app/bhandler/UnlockLooperTest.cpp
M src/tests/kits/app/bmessagerunner/MessageRunnerTest.cpp
M src/tests/kits/app/bmessenger/SMTarget.cpp
M src/tests/kits/app/broster/RosterTest.cpp
M src/tests/kits/interface/OutlineListViewTest.cpp
M src/tests/kits/interface/bdeskbar/DeskbarAddItemTest.cpp
M src/tests/kits/media/MediaKitTestAddon.cpp
M src/tests/kits/net/service/HttpTest.cpp
M src/tests/kits/shared/CalendarViewTest.cpp
M src/tests/kits/storage/NodeTest.cpp
M src/tests/kits/storage/NodeTest.h
M src/tests/kits/storage/StorageKitTestAddon.cpp
M src/tests/kits/support/barchivable/InstantiateObjectTester.cpp
M src/tools/cppunit/TestShell.cpp
15 files changed, 67 insertions(+), 43 deletions(-)


  git pull ssh://git.haiku-os.org/haiku refs/changes/65/465/4
--
To view, visit https://review.haiku-os.org/465
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7d55f4622192f83572bfd83fa37f1f5fd641e22
Gerrit-Change-Number: 465
Gerrit-PatchSet: 4
Gerrit-Owner: Kacper Kasper <kacperkasper@xxxxxxxxx>
Gerrit-Reviewer: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Gerrit-Reviewer: Jérôme Duval <jerome.duval@xxxxxxxxx>
Gerrit-Reviewer: Kacper Kasper <kacperkasper@xxxxxxxxx>
Gerrit-Reviewer: waddlesplash <waddlesplash@xxxxxxxxx>

Other related posts: