From Adrien Destugues <pulkomandy@xxxxxxxxx>:
Adrien Destugues has uploaded this change for review. (
https://review.haiku-os.org/c/haiku/+/1588
Change subject: PluginManager: remove unneeded buffering.
......................................................................
PluginManager: remove unneeded buffering.
The plugin manager was attempting to buffer the IOs. However, the ffmpeg
plugin already handles this (it reads in 64K chunks, the same size as
the buffer here, so this buffering was effectively useless), and the
media extractor already runs the decoding in a separate thread thanks to
the chunk cache. So, we do not need an extra level of buffering here.
We should leave any extra buffering to the upper layers (BMediaTrack or
Media Extractor), if it's needed, as they would have much more control
on the creation of the data io object.
---
M src/kits/media/PluginManager.cpp
1 file changed, 9 insertions(+), 29 deletions(-)
git pull ssh://git.haiku-os.org:22/haiku refs/changes/88/1588/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1588
To unsubscribe, or for help writing mail filters, visit
https://review.haiku-os.org/settings
Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I65b67919da107c8b910dd08f8cdb8e3745af92c7
Gerrit-Change-Number: 1588
Gerrit-PatchSet: 1
Gerrit-Owner: Adrien Destugues <pulkomandy@xxxxxxxxx>
Gerrit-MessageType: newchange
