[haiku-commits] Change in haiku[master]: Package Server: clobber files when commiting transaction

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 2 Jan 2021 14:40:27 +0000

From Stephan Aßmus <superstippi@xxxxxx>:

Stephan Aßmus has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3597 ;)


Change subject: Package Server: clobber files when commiting transaction
......................................................................

Package Server: clobber files when commiting transaction

Package files to be committed may already exist in the packages folder,
there is no good reason to fail the transaction. These may be packages
which are not activated, or there may be other reasons. While I have
not investigated how this situation may form, I don't see a good reason
to spend the time. Simply move the BEntry with "clobber = true".

Change-Id: I2a574df38385c8dead8bac2beace94436d43760a
---
M src/servers/package/CommitTransactionHandler.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/97/3597/1

diff --git a/src/servers/package/CommitTransactionHandler.cpp 
b/src/servers/package/CommitTransactionHandler.cpp
index 667a1f3..69cfdb4 100644
--- a/src/servers/package/CommitTransactionHandler.cpp
+++ b/src/servers/package/CommitTransactionHandler.cpp
@@ -589,7 +589,7 @@
                // move entry
                fAddedPackages.insert(package);

-               error = entry.MoveTo(&packagesDirectory);
+               error = entry.MoveTo(&packagesDirectory, NULL, true);
                if (error != B_OK) {
                        fAddedPackages.erase(package);
                        ERROR("Failed to move new package %s to packages 
directory: %s\n",

--
To view, visit https://review.haiku-os.org/c/haiku/+/3597
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I2a574df38385c8dead8bac2beace94436d43760a
Gerrit-Change-Number: 3597
Gerrit-PatchSet: 1
Gerrit-Owner: Stephan Aßmus <superstippi@xxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Package Server: clobber files when commiting transaction - Gerrit