[haiku-commits] Change in ...haiku[master]: Menu tracking: Re-apply Stefano's patch from #1621

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 5 Aug 2019 02:36:46 +0000

From Ryan Leavengood <leavengood@xxxxxxxxx>:

Ryan Leavengood has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/1678


Change subject: Menu tracking: Re-apply Stefano's patch from #1621
......................................................................

Menu tracking: Re-apply Stefano's patch from #1621

The idea is to simplify menu tracking by using Mouse hooks.

I had to manually apply the patch and I know a lot has changed since it was
written.

This compiles but functionality is totally broken. One menu will open and track
mouse movements, but no other menus open, selecting items doesn't trigger
anything and the one menu won't close. Obviously a ton of needed code has been
removed or commented out. It will take me a while to sort it out, but I at
least wanted to give it a try and get it pushed up to Gerrit.
---
M headers/os/interface/Menu.h
M headers/os/interface/MenuBar.h
M headers/private/interface/BMCPrivate.h
M headers/private/interface/MenuPrivate.h
M src/kits/interface/BMCPrivate.cpp
M src/kits/interface/Menu.cpp
M src/kits/interface/MenuBar.cpp
M src/kits/interface/PopUpMenu.cpp
M src/kits/interface/Window.cpp
9 files changed, 374 insertions(+), 412 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/78/1678/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1678
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: If0500dffccf9e32c4b003e4d2484eec0ebab2f0d
Gerrit-Change-Number: 1678
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Leavengood <leavengood@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in ...haiku[master]: Menu tracking: Re-apply Stefano's patch from #1621 - Gerrit