[haiku-commits] Change in haiku[master]: Input preferences: fix list item retrieval

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 20 Dec 2020 20:57:09 +0000

From Máximo Castañeda <antiswen@xxxxxxxx>:

Máximo Castañeda has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3540 ;)


Change subject: Input preferences: fix list item retrieval
......................................................................

Input preferences: fix list item retrieval

Fixes #16679

Change-Id: I87844b7745dc2d9e126983a888caf01f37f6b742
---
M src/preferences/input/InputWindow.cpp
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/40/3540/1

diff --git a/src/preferences/input/InputWindow.cpp 
b/src/preferences/input/InputWindow.cpp
index 7c19ed4..ca2e095 100644
--- a/src/preferences/input/InputWindow.cpp
+++ b/src/preferences/input/InputWindow.cpp
@@ -115,9 +115,9 @@
                        } else {
                                for (int i = 0; i < 
fDeviceListView->CountItems();
                                        i++) {
-                                       BStringItem* item = 
dynamic_cast<BStringItem*>(
-                                               fDeviceListView->ItemAt(i));
-                                       if (item->Text() == name) {
+                                       const char* itemName = 
dynamic_cast<DeviceListItemView*>(
+                                               
fDeviceListView->ItemAt(i))->Label();
+                                       if (itemName == name) {
                                                fDeviceListView->RemoveItem(i);
                                                BView* settings = 
fCardView->ChildAt(i);
                                                
fCardView->RemoveChild(settings);

--
To view, visit https://review.haiku-os.org/c/haiku/+/3540
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I87844b7745dc2d9e126983a888caf01f37f6b742
Gerrit-Change-Number: 3540
Gerrit-PatchSet: 1
Gerrit-Owner: Máximo Castañeda <antiswen@xxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Input preferences: fix list item retrieval - Gerrit