[haiku-commits] Change in haiku[master]: Input: fix MouseView drawing

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 28 Jun 2020 12:33:49 +0000

From X512 <danger_mail@xxxxxxx>:

X512 has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2960 ;)


Change subject: Input: fix MouseView drawing
......................................................................

Input: fix MouseView drawing

BeginPicture/EndPicture do not save state so origin should be restored
after recording picture. BView::Draw use PushState internally so origin
is added and cause problem.

hrev54347 fixed behavior when recording picture so state change is
affected. It revealed #16317 bug.

Fixes #16317.

Change-Id: Iee69631ce83fea5ea73c99b492b8cf67d1b148c7
---
M src/preferences/input/MouseView.cpp
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/60/2960/1

diff --git a/src/preferences/input/MouseView.cpp 
b/src/preferences/input/MouseView.cpp
index 19db856..edef4ab 100644
--- a/src/preferences/input/MouseView.cpp
+++ b/src/preferences/input/MouseView.cpp
@@ -377,5 +377,6 @@
        FillShape(&mouseShape, B_SOLID_HIGH);

        EndPicture();
+       SetOrigin(0, 0);
        SetScale(1);
 }

-- 
To view, visit https://review.haiku-os.org/c/haiku/+/2960
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Iee69631ce83fea5ea73c99b492b8cf67d1b148c7
Gerrit-Change-Number: 2960
Gerrit-PatchSet: 1
Gerrit-Owner: X512 <danger_mail@xxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Input: fix MouseView drawing - Gerrit