[haiku-commits] Change in haiku[master]: IconCache: remove incorrect ASSERT()

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 26 Aug 2019 19:37:53 +0000

From Adrien Destugues <pulkomandy@xxxxxxxxx>:

Adrien Destugues has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/1749 ;)


Change subject: IconCache: remove incorrect ASSERT()
......................................................................

IconCache: remove incorrect ASSERT()

The code does just fine both if entry is NULL and if it doesn't have an
icon. However, if entry is NULL, this assert calls a method on it, which
is a bad idea.
---
M src/kits/tracker/IconCache.cpp
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/49/1749/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1749
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I80b314db373970d99eb008aeaec6254d14c39ca7
Gerrit-Change-Number: 1749
Gerrit-PatchSet: 1
Gerrit-Owner: Adrien Destugues <pulkomandy@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: IconCache: remove incorrect ASSERT() - Gerrit