[haiku-commits] Change in haiku[master]: Deskbar: Move InlineScrollView and ResizeControl off screen in mini-mode

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 9 Mar 2020 10:33:55 +0000

From John Scipione <jscipione@xxxxxxxxx>:

John Scipione has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/2333 ;)


Change subject: Deskbar: Move InlineScrollView and ResizeControl off screen in 
mini-mode
......................................................................

Deskbar: Move InlineScrollView and ResizeControl off screen in mini-mode

Fixes #15792
---
M src/apps/deskbar/BarView.cpp
1 file changed, 11 insertions(+), 3 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/33/2333/1

diff --git a/src/apps/deskbar/BarView.cpp b/src/apps/deskbar/BarView.cpp
index 09cc4a0..03ffcbf 100644
--- a/src/apps/deskbar/BarView.cpp
+++ b/src/apps/deskbar/BarView.cpp
@@ -204,8 +204,13 @@
        AddChild(fInlineScrollView);

        // hide the expando menu bar in mini-mode
-       if (state == kMiniState)
-               fInlineScrollView->Hide();
+       if (state == kMiniState) {
+               if (!fInlineScrollView->IsHidden()) {
+                       fInlineScrollView->Hide();
+                       // hiding is not enough, put somewhere no one will ever 
see it
+                       fInlineScrollView->MoveTo(-10000, 10000);
+               }
+       }

        // if auto-hide is on and we're not already hidden, hide ourself
        if (fBarApp->Settings()->autoHide && !IsHidden())
@@ -576,8 +581,11 @@
                        fResizeControl->Show();
        } else {
                // hide resize control
-               if (!fResizeControl->IsHidden())
+               if (!fResizeControl->IsHidden()) {
                        fResizeControl->Hide();
+                       // hiding is not enough, put somewhere no one will ever 
see it
+                       fResizeControl->MoveTo(10000, -10000);
+               }
        }

        fDragRegion->Invalidate();

--
To view, visit https://review.haiku-os.org/c/haiku/+/2333
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I07a6453853bc3df64817689a055a6f4c8212d5ba
Gerrit-Change-Number: 2333
Gerrit-PatchSet: 1
Gerrit-Owner: John Scipione <jscipione@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: Deskbar: Move InlineScrollView and ResizeControl off screen in mini-mode - Gerrit