[haiku-commits] Change in ...haiku[master]: BeDecorator Draw outer left close button bevel to the edge

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 19 Feb 2019 05:09:15 +0000

From John Scipione <jscipione@xxxxxxxxx>:

John Scipione has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/1066


Change subject: BeDecorator Draw outer left close button bevel to the edge
......................................................................

BeDecorator Draw outer left close button bevel to the edge

... just like BeOS R5 did.

In 31234326741231bb8d36456ce9dbdccec7ce0e3b (hrev52122) I wrote:

"Undraw the bottom left and top right corners of bitmaps in the
unpressed state. BeOS did not do this (usually), but it should
have as it closes the ring."

This was a bad idea, draw like BeOS R5 instead.
---
M src/add-ons/decorators/BeDecorator/BeDecorator.cpp
1 file changed, 0 insertions(+), 16 deletions(-)



  git pull ssh://git.haiku-os.org/haiku refs/changes/66/1066/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1066
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I4eba7566bb31d3e208bc30439b0221b70eeb2bbe
Gerrit-Change-Number: 1066
Gerrit-PatchSet: 1
Gerrit-Owner: John Scipione <jscipione@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in ...haiku[master]: BeDecorator Draw outer left close button bevel to the edge - Gerrit