[haiku-commits] Change in ...haiku[master]: BSD headers: remove _BSD_SOURCE feature gate for sysexits.h

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 3 Mar 2019 20:47:52 +0000

From Niels Sascha Reedijk <niels.reedijk@xxxxxxxxx>:

Niels Sascha Reedijk has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/1144


Change subject: BSD headers: remove _BSD_SOURCE feature gate for sysexits.h
......................................................................

BSD headers: remove _BSD_SOURCE feature gate for sysexits.h

During the compilation of LLVM version 8, the build failed because it depends
on a constant in this file. In hrev49042 all BSD headers were feature-gated by
_BSD_SOURCE. This is not done (for this file) in glibc and (obviously) not in
BSD's libc.

Since this is not common practise, I would propose removing the feature gate
for this header file, as it would mean that we would have to upstream patches
for ports of other software that depends on the availability of these
constants.
---
M headers/compatibility/bsd/sysexits.h
1 file changed, 0 insertions(+), 6 deletions(-)



  git pull ssh://git.haiku-os.org/haiku refs/changes/44/1144/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1144
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I486f0c2e87eff489ce92d03589a6299ef1be6ca5
Gerrit-Change-Number: 1144
Gerrit-PatchSet: 1
Gerrit-Owner: Niels Sascha Reedijk <niels.reedijk@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in ...haiku[master]: BSD headers: remove _BSD_SOURCE feature gate for sysexits.h - Gerrit