[haiku-commits] Change in ...haiku[master]: BFS: Eliminate invalid use of non-static data member

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 14 Jun 2019 16:59:31 +0000

From John Scipione <jscipione@xxxxxxxxx>:

John Scipione has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/1503


Change subject: BFS: Eliminate invalid use of non-static data member
......................................................................

BFS: Eliminate invalid use of non-static data member

clang complains about this line, some explination:
https://stackoverflow.com/questions/29359661/clang-error-invalid-use-of-non-static-data-member
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2253.html

Referencing a non-static data member inside a struct was retroactively
made undefined in C++98 and only allowed on C++11 even though gcc
permits the code to compile. In this case it was an easy fix to get
the size from the instance instead.

No change to functionality intended.
---
M src/add-ons/kernel/file_systems/bfs/CheckVisitor.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/03/1503/1
--
To view, visit https://review.haiku-os.org/c/haiku/+/1503
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ic6bc332cf2796c709584488c60a067cd341bf894
Gerrit-Change-Number: 1503
Gerrit-PatchSet: 1
Gerrit-Owner: John Scipione <jscipione@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in ...haiku[master]: BFS: Eliminate invalid use of non-static data member - Gerrit