[haiku-commits] Change in haiku[master]: ACPICA fixes for gcc2.95.3

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 31 Jan 2021 15:19:47 +0000

From Fredrik Holmqvist <fredrik.holmqvist@xxxxxxxxx>:

Fredrik Holmqvist has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3723 ;)


Change subject: ACPICA fixes for gcc2.95.3
......................................................................

ACPICA fixes for gcc2.95.3

pswalk has issues in code we don't use for gcc 2.95.3, so just disable
Can we drop gcc2.95.3 soon?
---
M src/add-ons/kernel/bus_managers/acpi/acpica/components/parser/pswalk.c
M src/add-ons/kernel/bus_managers/acpi/acpica/include/actypes.h
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/23/3723/1

diff --git 
a/src/add-ons/kernel/bus_managers/acpi/acpica/components/parser/pswalk.c 
b/src/add-ons/kernel/bus_managers/acpi/acpica/components/parser/pswalk.c
index 0d5b78d..de1167a 100644
--- a/src/add-ons/kernel/bus_managers/acpi/acpica/components/parser/pswalk.c
+++ b/src/add-ons/kernel/bus_managers/acpi/acpica/components/parser/pswalk.c
@@ -193,7 +193,7 @@
         if (Op != Parent)
         {
             /* This is the descending case */
-
+#if 0 //gcc2.95.3 warns about printf format in code we do not use
             if (ACPI_IS_DEBUG_ENABLED (ACPI_LV_PARSE_TREES, _COMPONENT))
             {
                 /* This debug option will print the entire parse tree */
@@ -211,7 +211,7 @@
                 }
                 AcpiOsPrintf ("\n");
             }
-
+#endif
             /* Look for an argument or child of the current op */

             Next = AcpiPsGetArg (Op, 0);
diff --git a/src/add-ons/kernel/bus_managers/acpi/acpica/include/actypes.h 
b/src/add-ons/kernel/bus_managers/acpi/acpica/include/actypes.h
index e98e636..e6d2e4b 100644
--- a/src/add-ons/kernel/bus_managers/acpi/acpica/include/actypes.h
+++ b/src/add-ons/kernel/bus_managers/acpi/acpica/include/actypes.h
@@ -1379,7 +1379,7 @@
 {
     UINT32                          Count;              /* Number of IDs in 
Ids array */
     UINT32                          ListSize;           /* Size of list, 
including ID strings */
-    ACPI_PNP_DEVICE_ID              Ids[];              /* ID array */
+    ACPI_PNP_DEVICE_ID              Ids[1];             /* ID array */

 } ACPI_PNP_DEVICE_ID_LIST;


--
To view, visit https://review.haiku-os.org/c/haiku/+/3723
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I334b5029f97ad66b46bd0054c05c75062fec27fc
Gerrit-Change-Number: 3723
Gerrit-PatchSet: 1
Gerrit-Owner: Fredrik Holmqvist <fredrik.holmqvist@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: ACPICA fixes for gcc2.95.3 - Gerrit