[haiku-commits] Re: BRANCH xyzzy-github.x86_64 - src/system/kernel/arch/x86/64 headers/posix/arch/x86_64 src/system/kernel/arch/x86/32 src/system/kernel/arch/x86 build/jam
- From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 30 Jul 2012 22:36:11 +0200
Alex Smith wrote:
> On 30 July 2012 19:55, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> > xyzzy-github.x86_64 wrote:
> > > +// Userspace signal handler wrapper, copied to the commpage.
> > > +FUNCTION(_user_signal_handler):
> >
> > The naming is a bit unfortunate, since the "_user_" prefix is used for
> > syscall implementations. Since the function is x86-64 specific something
> > like "x86_64_user_signal_handler" would be appropriate.
>
> Ah, I'll change it. I'd been looking at the x86 commpage syscall functions
> which are named _user_*, which is why I named it like that.
I wondered whether you copied the naming from someone, but apparently missed
those. They should be renamed, too.
CU, Ingo
Other related posts:
