[haiku-commits] Re: BRANCH xyzzy-github.x86_64 - src/system/kernel/arch/x86/64 headers/posix/arch/x86_64 src/system/kernel/arch/x86/32 src/system/kernel/arch/x86 build/jam
- From: Alex Smith <alex@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 30 Jul 2012 21:14:22 +0100
On 30 July 2012 19:55, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> xyzzy-github.x86_64 wrote:
> > diff --git a/src/system/kernel/arch/x86/64/signals_asm.S
> b/src/system/kernel/arch/x86/64/signals_asm.S
> > new file mode 100644
> > index 0000000..078a4c1
> > --- /dev/null
> > +++ b/src/system/kernel/arch/x86/64/signals_asm.S
> > @@ -0,0 +1,56 @@
> > +/*
> > + * Copyright 2012, Alex Smith, alex@xxxxxxxxxxxxxxxxx
> > + * Distributed under the terms of the MIT License.
> > + */
> > +
> > +
> > +#include <asm_defs.h>
> > +
> > +#include "asm_offsets.h"
> > +#include "syscall_numbers.h"
> > +
> > +
> > +.text
> > +
> > +
> > +// Userspace signal handler wrapper, copied to the commpage.
> > +FUNCTION(_user_signal_handler):
>
> The naming is a bit unfortunate, since the "_user_" prefix is used for
> syscall implementations. Since the function is x86-64 specific something
> like "x86_64_user_signal_handler" would be appropriate.
>
Ah, I'll change it. I'd been looking at the x86 commpage syscall functions
which are named _user_*, which is why I named it like that.
Thanks,
Alex
Other related posts:
