[haiku-commits] Re: BRANCH xyzzy-github.x86_64 - in src/system/kernel/arch/x86/paging: . src/system
- From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 04 Jul 2012 22:26:42 +0200
xyzzy-github.x86_64 wrote:
> diff --git
> a/src/system/kernel/arch/x86/paging/x86_physical_page_mapper_mapped.cpp
> b/src/system/kernel/arch/x86/paging/x86_physical_page_mapper_mapped.cpp
> index 45f270c..d74fb7c 100644
> --- a/src/system/kernel/arch/x86/paging/x86_physical_page_mapper_mapped.cpp
> +++ b/src/system/kernel/arch/x86/paging/x86_physical_page_mapper_mapped.cpp
[...]
> +status_t
> +MappedPhysicalPageMapper::MemcpyFromPhysical(void* to, phys_addr_t _from,
> + size_t length, bool user)
> +{
> + if (_from >= KERNEL_PMAP_SIZE || _from + length > KERNEL_PMAP_SIZE)
> + return B_BAD_ADDRESS;
> +
> + void* from = (void*)(_from + KERNEL_PMAP_BASE);
> +
> + if (user)
> + return user_memcpy(to, from, length);
> + else
> + memcpy(to, from, length);
Please omit the "else" in such a case (also when doing a "break" at the end of
an "if" block in a loop).
> +
> + return B_OK;
> +}
[...]
CU, Ingo
Other related posts:
