[haiku-commits] Re: BRANCH tqh-github.efi_pm [b1724ed] src/system/boot/platform/efi

  • From: Fredrik Holmqvist <fredrik.holmqvist@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 15 Mar 2014 17:57:50 +0100

2014-03-15 17:04 GMT+01:00 Ingo Weinhold <ingo_weinhold@xxxxxx>:
> On 03/15/2014 11:16 AM, tqh-github.efi_pm wrote:
>>
>> b1724ed: Adding copy of mmu.h from ../bios_ia32.
>
>
> For 32 bit the code should simply be reused/refactored instead of being
> copied. For 64 bit the long mode switch part is superfluous. And it is
> probably possible to refactor the 32 bit code to reuse parts of it. In fact,
> there's probably quite a bit of code that could be reused for other
> architectures as well. The architecture interface in the kernel uses a lower
> level, thus reducing code duplication. I don't see why that shouldn't be
> possible in the boot loader as well.
>
> Actually, one thing that ails our other architecture ports generally is that
> x86 code is often copied and modified instead of refactoring it, interfacing
> at a more appropriate level.

Point taken, probably should just remove dependency on mmu.h for the
time being as I hope it will be done in GSoC.

/Fredrik Holmqvist, TQH

Other related posts: