[haiku-commits] Re: BRANCH pdziepak-github.nfs4 - src/add-ons/kernel/file_systems/nfs4
- From: Pawel Dziepak <pdziepak@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 2 Jul 2012 21:39:21 +0200
2012/7/2 Jérôme Duval <korli@xxxxxxxxxxxxxxxx>:
> 2012/7/2 pdziepak-github.nfs4 <community@xxxxxxxxxxxx>:
>> + status_t _ConfirmOpen(const
>> Filehandle& fh,
>> +
>> OpenFileCookie* cookie);
>
> Please use meaningful names when possible.
I guess the problem is with "fh". NFSv4 specification [1] uses "fh" as
an abbreviation for "filehandle" very commonly (operations like PUTFH,
GETFH, data type nfs_fh4, etc) and that's why I also use that name. If
it is a problem I can change that argument name, but I don't really
think that "fh" in the implementation of a NFSv4 client is not
meaningful enough.
Paweł
[1] http://tools.ietf.org/html/rfc3530
Other related posts:
