[haiku-commits] Re: BRANCH pdziepak-github.aslr - src/system/kernel/vm headers/os/kernel
- From: Pawel Dziepak <pdziepak@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 26 Feb 2013 22:50:45 +0100
2013/2/26 Ryan Leavengood <leavengood@xxxxxxxxx>:
> On Mon, Feb 25, 2013 at 5:31 PM, Pawel Dziepak <pdziepak@xxxxxxxxxxx> wrote:
>>
>> Still haven't got rid of habit of avoiding long names completely.
>> I will amend this commit and change the name to
>> B_RANDOMIZED_BASE_ADDRESS, since it is not "random base address", but
>> rather: "randomized, base address".
>
> If you mean amend as in git commit --amend, it is best not to amend
> commits which have already been pushed to a remote repository.
I am aware of that, but since it is my "private" repository and its
only purpose is to get reviews here most of the reasons against
amending already pushed commits is no longer valid. Especially since
these changes are style fixes and cleanups I believe it is worth it
and keeping aslr branch history neat.
Paweł
Other related posts:
