[haiku-commits] Re: BRANCH mmadia-github.separate-build-environment - in headers/build/posix_target: . headers/build

  • From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 15 Aug 2012 00:57:55 +0200

Matt Madia wrote:
> On 8/14/12, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> > On 2012-08-14 at 01:32:30 [+0200], Matt Madia <mattmadia@xxxxxxxxx> wrote:
> >> On 8/11/12, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> >> > On 2012-08-10 at 17:49:19 [+0200],
> >> > mmadia-github.separate-build-environment
> >> > <community@xxxxxxxxxxxx> wrote:
> >> >> diff --git a/headers/build/posix_target/target_stdio_ext.h
> >> >> diff --git a/headers/build/posix_target/target_stdio_post.h
> >> >
> >> > Neither is needed.
> >>
> >> I thought you wanted empty files created, to ensure that their
> >> contents wouldn't be picked up or what have you.
> >
> > Only in headers/build/posix. Nobody includes the posix_target headers.
> 
> Can headers/build/posix_target/target_stdio_pre.h be removed as well?
> At the moment, it's an empty header too.

Um, I snipped the wrong line. I meant [target_]stdio_{pre,post}.h aren't 
needed. stdio_ext.h isn't standard, but apparently supported not only by glibc. 
So, at least theoretically it might be used. But you can add target_stdio_ext.h 
when it is actually needed respectively leave it empty for now. Basically that 
holds true for any target_* header. You only need to add the functionality to 
them that is actually needed (i.e. used), though it doesn't harm to add more 
either.

CU, Ingo

Other related posts: