[haiku-commits] Re: BRANCH mmadia-github.separate-build-environment - in headers/build/posix_target: . headers/build

  • From: Matt Madia <mattmadia@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 13 Aug 2012 19:32:30 -0400

On 8/11/12, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> On 2012-08-10 at 17:49:19 [+0200], mmadia-github.separate-build-environment
> <community@xxxxxxxxxxxx> wrote:
>> diff --git a/headers/build/posix_target/target_stdio.h
>> +#define _haiku_build_getc(stream) \
>> +    (_single_threaded ? _haiku_build_getc_unlocked(stream) :
>> _haiku_build_getc(stream))
>> +#define _haiku_build_putc(c, stream) \
>> +    (_single_threaded ? _haiku_build_putc_unlocked(c, stream) :
>> _haiku_build_putc(c, stream))
>
> Those should be defined as functions instead (check the POSIX specs for
> their
> signature). Omit _haiku_build_{get,put}c_unlocked().

Added as a TODO.  :]

>> diff --git a/headers/build/posix_target/target_stdio_ext.h
>> diff --git a/headers/build/posix_target/target_stdio_post.h
>
> Neither is needed.

I thought you wanted empty files created, to ensure that their
contents wouldn't be picked up or what have you.

--mmadia

Other related posts: