[haiku-commits] Re: BRANCH mmadia-github.separate-build-environment - in headers/build: posix_target os_target/kernel
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 14 Aug 2012 11:33:12 +0200
On 2012-08-14 at 01:49:24 [+0200], mmadia-github.separate-build-environment
<community@xxxxxxxxxxxx> wrote:
> ----------------------------------------------------------------------------
>
> 3 files changed, 201 insertions(+), 125 deletions(-)
> headers/build/os_target/kernel/target_fs_attr.h | 10 +-
> headers/build/posix_target/target_dirent.h | 48 ++--
> headers/build/posix_target/target_stdio.h | 268 ++++++++++++-------
>
> ############################################################################
>
> Commit: bba69677e2aa083412d50e8ca8e305abda1a84fe
>
> Author: Matt Madia <mattmadia@xxxxxxxxx>
> Date: Mon Aug 13 23:16:27 2012 UTC
>
> Changes from commit review.
>
> * Wrapped FILE.
> * Removed HAIKU_BUILD_DECLARE_VARIABLE(char, _single_threaded)
> * Removed _haiku_build_{get,put}c_unlocked()
They still seem to be there. Which is fine -- I just noticed they are
actually POSIX.
> * Added a TODO about _haiku_build_[get,put]c()
>
> ----------------------------------------------------------------------------
>
> diff --git a/headers/build/posix_target/target_stdio.h
> b/headers/build/posix_target/target_stdio.h
> index e8594b8..df57653 100644
> --- a/headers/build/posix_target/target_stdio.h
> +++ b/headers/build/posix_target/target_stdio.h
> @@ -107,7 +107,8 @@ typedef _haiku_build_off_t fpos_t;
> Start with an empty file and only add something, if actually used.
> */
> //#include <target_stdio_pre.h>
> -typedef struct _HAIKU_BUILD_IDENTIFIER(_IO_FILE) FILE;
> +struct _HAIKU_BUILD_IDENTIFIER(_FILE);
> +typedef _HAIKU_BUILD_IDENTIFIER(_FILE) _HAIKU_BUILD_IDENTIFIER(FILE);
There needs to be a "struct" after the "typedef" to make the C compiler
happy. Same for DIR.
CU, Ingo
Other related posts:
