[haiku-commits] Re: BRANCH midar-github.master - in src: kits/app kits/support apps/soundrecorder kits/locale

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 19 Nov 2012 20:39:54 +0100

On 11/19/2012 06:00 PM, midar-github.master wrote:

Commit:      fa6386cbdac306b21fbd3e8d01eeb2f4f57ed524
Author:      Jonathan Schleifer <js@xxxxxxxxxxx>
Date:        Mon Nov 19 16:21:44 2012 UTC

Make libbe compile with Clang.

----------------------------------------------------------------------------

diff --git a/headers/private/app/LooperList.h b/headers/private/app/LooperList.h
index 7bdc824..b2ed2ba 100644
--- a/headers/private/app/LooperList.h
+++ b/headers/private/app/LooperList.h
@@ -43,7 +43,6 @@ public:

                        void                            InitAfterFork();

-private:
        struct LooperData {
                LooperData();
                LooperData(BLooper* looper);
@@ -52,6 +51,8 @@ private:

                BLooper*        looper;
        };
+
+private:
        struct FindLooperPred {
                FindLooperPred(const BLooper* loop) : looper(loop) {}
                bool operator()(LooperData& Data);
Whatever clang doesn't like (probably the LooperDataIterator typedef), it should be solved differently (e.g. by moving the typedef into the class). The LooperData structure is meant to be private. It doesn't matter all that much, since BLooperList is implementation private, but nonetheless things should be kept as clean as possible. 

CU, Ingo

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 11-2012