[haiku-commits] Re: BRANCH jessicah-github.efi.merge [5a70dd7f18df] src/tests/kits/interface/flatten_picture src/system/boot/loader src/system/boot/platform/efi data/catalogs/add-ons/network_settings data/catalogs/apps

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 24 Sep 2015 11:19:22 +0200

Am 24/09/2015 um 10:52 schrieb Ingo Weinhold:

+ uint8 uuid[16];
} partition_data;
Not sure about this. Since UUIDs aren't universally used by partitioning
systems, it doesn't feel quite right to add such a field here. The

I had the same feeling, but didn't have a better idea.

Alternatively, instead of passing a UUID from the boot loader it could
be more generally a URI. Then either such a field is added to
partition_data and compared directly or a partition system hook is added
returning the confidence level that a given ID identifies the partition
(or both).

How would that URI look like?
You mean something like urn:uuid:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx?
Would work for me.

At any rate, when adding a field to partition data, KPartition should be
adjusted. At least the constructor to initialize the field, but probably
better also UninitializeContents(), Dump(), and WriteUserData() (and
with it the userland side).

Yeah, makes sense; I completely forgot about that.

Bye,
Axel.

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 09-2015