[haiku-commits] Re: BRANCH jessicah-github.desklink [bf1e9de5641b] in src: kits/media bin/desklink

  • From: Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Mon, 16 Jan 2017 03:26:19 +1300

On 16 January 2017 at 03:15, jessicah-github.desklink
<community@xxxxxxxxxxxx> wrote:

added 2 changesets to branch 'refs/remotes/jessicah-github/desklink'
old head: 0988c65d472772008c2e89ec8a9499524ddd51a8
new head: bf1e9de5641b7dd426f87900c0bbd80ad5eeb6dc
overview: 
https://github.com/jessicah/haiku/compare/0988c65d4727...bf1e9de5641b

----------------------------------------------------------------------------

4f581d85c815: DefaultMediaTheme: improve watching for parameter value changes.

  * Addresses TODO of sub-classing controls, registering with the
    media roster for parameter changes.
  * Also adds support for discrete parameter controls, which didn't
    have this functionality.
  * With this change, the controls no longer need to be focused or
    modified for the parameter changes to register.

bf1e9de5641b: desklink: use media_server notifications instead of polling.

  * This removes Pulse(), which would constantly reconnect to
    the mixer. With the previous changes to the
    DefaultMediaTheme, this also makes changes to the muted
    state instaneous when modified by some other app.

                         [ Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx> ]

----------------------------------------------------------------------------

I would appreciate some review of these commits before pushing to
master, as, at least in my VM, occasionally the desktop doesn't start.

Entering KDL and the teams list, neither Tracker or Deskbar are
present. Restarting the desktop from ctrl+alt+del window, none of the
replicants are loaded either. I don't really understand how my changes
could cause this. I've checked my syslogs, and I can't see any errors
from launch_daemon, or anything relating to Tracker & Deskbar =/

Other related posts: