[haiku-commits] Re: BRANCH axeld-github.imap [91f396f] in src: add-ons/mail_daemon/inbound_protocols/imap/imap_lib tests/add-ons/mail/imap add-ons/mail_daemon/inbound_protocols/imap

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 30 May 2013 16:01:31 +0200

Am 29/05/2013 22:47, schrieb John Scipione:

On Wed, May 29, 2013 at 12:15 PM, axeld-github.imap
<community@xxxxxxxxxxxx> wrote:

+                       bool                            fUIDs;

Definitely a nitpick, but, shouldn't the variable name be a verb since
it's a bool, something like fFetchUIDs or fShouldFetchUIDs rather than
just UIDs? To some it might look it is fUIDs references a list of UIDs
rather than a flag.
Yeah, I guess you're right, will change next time I have the chance to work on it. Thanks for proof-reading! 

Bye,
   Axel.

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 05-2013