[haiku-commits] Re: AW: haiku: hrev47800 - src/add-ons/kernel/drivers/audio/hda

  • From: Julian Harnath <julian.harnath@xxxxxxxxxxxxxx>
  • To: <haiku-commits@xxxxxxxxxxxxx>
  • Date: Wed, 3 Sep 2014 19:38:14 +0200

Hey,

Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> schrieb:
> Julian wrote:
> > 84dfba2: Preserve reserved bits in registers
>
> Is that actually necessary? Usually you are allowed to keep these to
> zero, or even should set them to zero (I haven't looked at the specs,
though, lazy me).

Yep, the HDA spec says the values have to be preserved by doing read-
modify-write, otherwise it could result in undefined hardware
behaviour. It goes even further, saying that the same must be done for
RO-bits as well... There's a bunch more stuff which needs changes to
adhere to the spec, but before fixing those I'd like to refactor the
driver into some C++ classes to make it easier to work with.

> You obviously just copied that issue, but the parenthesis around
> gPci->read_pci_config are superfluous.
> [...]
> Something happened here to the formatting.

Right, I'll fix those style issues.

--
So long, Julian

Other related posts: