[haiku-bugs] Re: [Haiku] #9672: False positive of alert prompt.

  • From: "jessicah" <trac@xxxxxxxxxxxx>
  • Date: Fri, 12 Sep 2014 21:00:38 -0000

#9672: False positive of alert prompt.
---------------------------------------+----------------------------
   Reporter:  mmadia                   |      Owner:  axeld
       Type:  bug                      |     Status:  closed
   Priority:  normal                   |  Milestone:  R1
  Component:  Applications/DriveSetup  |    Version:  R1/Development
 Resolution:  fixed                    |   Keywords:
 Blocked By:                           |   Blocking:
Has a Patch:  1                        |   Platform:  All
---------------------------------------+----------------------------

Comment (by jessicah):

 Replying to [comment:8 korli]:
 > Replying to [comment:7 axeld]:
 > > Unfortunately, I missed this ticket; I'm not really fond of the
 suggested solution. Moving the dev_t to an argument doesn't really improve
 anything, so I think it should be reverted again, and the DriveSetup bug
 fixed instead (sorry for that one).
 >
 > In this case, the documentation for BPartition::Mount() needs to be
 fixed too.

 The documentation was updated. Also, the already existing documentation
 says it returns B_OK on success, not a dev_t; so whilst it has returned a
 dev_t since forever, it also says it returns B_OK on success since
 forever.

 Is there any reason we even need to expose the dev_t handle here anyway?

--
Ticket URL: <https://dev.haiku-os.org/ticket/9672#comment:9>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: