#9604: PatchBay update for Haiku ----------------------------+------------------------- Reporter: Pete | Owner: nobody Type: enhancement | Status: new Priority: normal | Milestone: R1 Component: Applications | Version: R1/alpha4.1 Resolution: | Keywords: Blocked By: | Blocking: 9159 Has a Patch: 1 | Platform: All ----------------------------+------------------------- Comment (by Pete): Replying to [comment:10 korli]: > OK, a few things: > * #ifndef _EndpointInfo_h, _EndpointInfo_h is usually uppercased, dunno if it's in the coding style guidelines.. Oops, yes -- shouldn't have missed that... > * In header files, there is no blank line between license text and header guard. OK > * there are a few occurrences of braces on their own lines along with a for or a if. OK > * the copyright license header doesn't follow the guidelines. Would you like to expand on that? I tried to figure out what was appropriate, and that was my best guess. > * "if (box)" should be "if (box != NULL)" Missed that too. [Maybe because that's one of the guidelines I don't agree with! (:-/)] > * "if (producer) producer->Release();" should be on two lines OK > * separate #include group with a newline OK > > Improvements to the checkstyle script are welcome too :) Yep... None of the above are caught by checkstyle.py. I'm probably not the one to make any improvements, though. (:-)) It really is hard for someone who normally uses a different style to notice all the variances in a large swathe of code, but I'll do my best. -- Ticket URL: <http://dev.haiku-os.org/ticket/9604#comment:11> Haiku <http://dev.haiku-os.org> Haiku - the operating system.